chore: check context in ngx.timer.* for exit process #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doujiang24
reviewed
Aug 17, 2021
README.markdown
Outdated
| @@ -8539,6 +8542,8 @@ table. It won't share the same `ngx.ctx` with the Lua handler creating the timer | |||
| If you need to pass data from the timer creator to the timer handler, please | |||
| use the extra parameters of `ngx.timer.at()`. | |||
|
|
|||
| Since nginx has been confirmed that all timers have been cleaned up when exit worker is executed, all timers will no longer be executed in exit worker phase. Reference <https://github.com/nginx/nginx/blob/f02e2a734ef472f0dcf83ab2e8ce96d1acead8a5/src/os/unix/ngx_process_cycle.c#L715>. | |||
There was a problem hiding this comment.
It's not allowed to create a timer (even a 0-delay timer) here since it runs after all timers have been processed.
better move this note to here?
https://github.com/openresty/lua-nginx-module/blob/e718d797cf28988251c329e247c7cd475d7e2bd9/README.markdown#exit_worker_by_lua_block
There was a problem hiding this comment.
And we can keep the reference only in the code comments.
rainingmaster
force-pushed
the
exit_process_with_timer
branch
from
e718d79 to
232469f
Compare
doujiang24
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
One ci is failed, but it is not related to this change.
https://app.travis-ci.com/github/openresty/lua-nginx-module/jobs/531916997#L922
spacewander
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since nginx has been confirmed that all timers have been cleaned up when exit worker is executed, all timers will no longer be executed in exit worker phase.
Reference https://github.com/nginx/nginx/blob/f02e2a734ef472f0dcf83ab2e8ce96d1acead8a5/src/os/unix/ngx_process_cycle.c#L715